Themes/Skins

[Buster's Uncle]

I definitely want to get the Shop stuff displaying in all the themes.  I can live without seeing everyone's Inventory, but I've used the fake forum money as a personal activity motivator since the beginning.  Just as well run the table.  It certainly raises the profile and usefullness of a bunch of silly goodies I put a lot of time into creating, and raises entertainment value of those forum goodies, which is what they are for

Also, no theme that doesn't show "Users Logged In Last 24 Hours" is a real candidate for default - I track that information.  I need to.

-Alas, these things are nothing I'm likely to ever raise my tech mojo to the level of figuring out/fixing by myself.

[DrazharLn]

Shop items are inserted by Display.template.php. I've made them display in SMAC by simply removing the SMAC theme's custom Display.template.php file. I recommend you try that as a first port of call for each theme you want to try and fix.

This may have caused other errors. If you see any in this or any other theme a partial change would be to simply copy this section:

Code: [Select]

      // Any custom fields for standard placement?
      if (!empty($message['member']['custom_fields']))
      {
        foreach ($message['member']['custom_fields'] as $custom)
          if (empty($custom['placement']) && !empty($custom['value']))
            echo '
            <li>', $custom['title'], ': ', $custom['value'], '</li>';
      }

into the section that starts with something like this line:

Code: [Select]

          <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

For reference, check Themes/core/Display.template.php for a correct implementation.

I find this stuff by inspecting the element that's missing (in this case the shop images), then searching the Themes directory for a likely string.

In this case, I found the code like so:

Code: [Select]

drazharln@alphacentauri2 in www
› ack _extra_info --php Themes
Themes/astronomy_22/Display.template.php
231: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
820: \'msg_', $msgid, '_extra_info\',

Themes/astronomy_22/PersonalMessage.template.php
203: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

Themes/core/Help.template.php
782: <ul id="msg_1_extra_info" class="reset smalltext">

Themes/core/Display.template.php
231: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
843: \'msg_', $msgid, '_extra_info\',

Themes/core/PersonalMessage.template.php
203: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

Themes/Redsy/Display.template.php
264: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
859: \'msg_', $msgid, '_extra_info\',

Themes/Redsy/PersonalMessage.template.php
214: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

Themes/default/Display.template.php
254: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
940: \'msg_', $msgid, '_extra_info\',

Themes/default/PersonalMessage.template.php
196: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

Themes/default/Aeva.template.php
457: <td valign="top" class="windowbg2"', $amSettings['show_extra_info'] == 1 ? ' rowspan="2"' : '', '>
551: if ($amSettings['show_extra_info'] == 1)
555: <div class="titlebg" style="margin: 0 -4px 2px -4px; padding: 7px 0 5px 8px"><h3>', $txt['aeva_extra_info'], '</h3></div>';
566: <div class="title_bar"><h3 class="titlebg ae_header" style="margin-bottom: 8px">' . $txt['aeva_extra_info'] . '</h3></div>' : '', '

Themes/default/languages/Aeva.french.php
206:$txt['aeva_extra_info'] = 'M�tadonn�es Exif';
516:$txt['aeva_admin_settings_show_extra_info'] = 'Montrer les donn�es Exif';

Themes/default/languages/Aeva.english.php
216:$txt['aeva_extra_info'] = 'Exif Metadata';
526:$txt['aeva_admin_settings_show_extra_info'] = 'Show Exif data';

Themes/default/languages/Aeva.french-utf8.php
206:$txt['aeva_extra_info'] = 'Métadonnées Exif';
516:$txt['aeva_admin_settings_show_extra_info'] = 'Montrer les données Exif';

Themes/smac/Display.template.php
264: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
860: \'msg_', $msgid, '_extra_info\',

Themes/smac/PersonalMessage.template.php
227: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

Themes/enterprise_smf20final/Display.template.php
254: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
940: \'msg_', $msgid, '_extra_info\',

Themes/Music_2_0/Display.template.php
243: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">
861: \'msg_', $msgid, '_extra_info\',

Themes/smax/Display.template.php
264: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';
860: \'msg_', $msgid, '_extra_info\',

Themes/smax/PersonalMessage.template.php
227: <ul class="reset smalltext" id="msg_', $message['id'], '_extra_info">';

From that, I just looked in the Themes/core/Display.template.php for that section and found something likely. You could try something similar for the Users logged in bit. Search on element ids or classes, not full text.

[Buster's Uncle]

...I'll need time to process this...  Nice work on the Shop display in SMAC.  Now I need to try the move Display.template.php trick elsewhere.



Everybody hit refresh, and have a look at THIS:


I figured out a clever background art workaround for the code junk that was balking me.  I am satisfied with Winter.

P.S.   

[DrazharLn]

When moving the Display.template.php, try just moving it to Display.template.php.disabled

That should stop SMF using it but keep it around for us to easily refer to and possibly regress to if necessary. I've moved the old smac theme Display.blah file back into the directory using that naming scheme, in case we need it.

Congratulations on the winter theme

[Valka]

A few comments:

1. I do not like "Redsy." At all.

2. I'm currently back to Enterprise, and the text in the Code-tagged posts above is invisible unless I mouse over it.

3. Not sure what's up with the Summer theme, when I'm trying to reply, the smileys and other parts of it keep marching right over the right-hand border (the vertical green strip, which I assume the smileys are not supposed to extend past).

[Buster's Uncle]

I moved Display.template.php for Green Core into its .css folder - and later moved it back.  It borked up too many things, like posts were sorta nesting.  Core is too heavily modded to do much more than the color change I already did, too many features don't work, and I'm thinking we don't need it.

The Enterprise problem sounds like a text color one I can track down.

I'll have a look at Summer - I wouldn't be a bit surprised if I didn't create that glitch.

I sorta want to cycle through the rest tweaking first, but of course I plan to eventually see what I can make of Redsy.


Any reason not to do Core, anyone?

[Valka]

Not sure what you mean by that - are you asking if we want to keep Core, modify it, or delete it? 

[Buster's Uncle]

...It's taking up a slot, and its only value is that that I snuck in Green1's avatar.  Other than that, it's both bland and defective.  I want to cast it into the outer (green) darkness, beyond the Wall of the world...


I was just in Redsy, and --- round avatars whether you want them or not in MY forum?  It's less likely than you think.  There's a whole laudry list of problems, no pagetop menu being a deal-breaker alone.

The only thing going for it is Draz liking it, and I DO mean only - or it would never have made the cut after my first look.  Toss that loser out there to keep Green Core company, and we're down to 12.

-And I still think we should choose between Halloween and Thanksgiving, which would make 11.

[Buster's Uncle]

Hmmm.  I'm in Lazy Summer in both IE and Chrome right now, and there's a problem I see in IE but not Chrome -probably two problems.  Draz' code boxes bork up the post display width and on the Reply page, it appears the Post Reply line right under the breadcrumbs is pushing the left sidebar off the page on the right, and all the previous posts are displaying wide - probably both the code box problem.

I haven't the foggiest how to tackle browser inconsistencies...

[Valka]

I don't mind losing Green Core and Redsy.

Has the underlining problem been fixed in Thanksgiving?

[Buster's Uncle]

Not by me - I'm stumped.

Gonna go defenestrate Green Core now...

[DrazharLn]

You're talking about the "Core" theme. Please only delete the "Green core" theme and not the "Core" pseudo theme. The "Core" theme is special and part of how SMF works.

The value of Redsy is that the html produced is very simple and clean and the css that styles it is also more easily modifiable. It's not there to be a great theme on its own and indeed has some serious problems. If you really don't want it there, I don't mind it being removed, but a slightly altered version of it would be a suitable base for making all these themes (or maybe an altered version of something with the same positive qualities but less different like Fastline. Needs more opacity, obviously).

As for the code boxes displaying too wide, do you mean the general problem on all themes? This would be easy to fix if our themes didn't do layout through html tables. As it is, this is proving hard to fix satisfactorily (evein in Redsy, which doesn't use tables - PortaMx helpfully inserts some tables).

In modern times, we fix browser inconsistencies partly by using normalisation css files, simpler html and css, and partly via a kind of witchrcaft. Most web designers stopped pandering to IE versions less than 8 or maybe 10 a while ago, though. You could try including normalize.css (google it) in the broken theme (can use an @include directive in index.css).

[Buster's Uncle]

I haven't deleted anything since I purged all the broken junk themes from the server.

Green Core is Core with green backgrounds altered in in the first place, and I've only turned it off as an available theme.  I think I'll do the same to Redsy today - but add the current missing images first, in case you want to bring it back and work on it in the future.  It's all easily undone, w/o even needing to reload anything.

[DrazharLn]

I found the css that was making the page display with an unneeded horizontal scrollbar and I've fixed it.

(It was the width: 98% attribute on the #main_menu class. I found it by inspecting the page and then deleting elements until I found it)

I've restricted the size of code elements and embedded images in the smac theme. It's not a great fix, because of the tables (tables make controlling the size of html elements really quite difficult). Please test on IE.

Code to restrict size of image:

Code: [Select]

.bbc_img
{
  ...
  max-width: 65vw;
  height: auto;
}

Code to restrict width of code elements:

Code: [Select]

code.bbc_code
{
  ...
  max-width: 65vw;
}

The two problems with this approach are that:

1) the vw (percentage of viewport width) unit is not well supported in older versions of IE
2) this is a bad hack that doesn't respect the space of other elements (i.e. the portaMX side bar) or the width of the central content column.

The first thing isn't so bad, browsers that don't understand the vw unit will just ignore it and be no worse off. The second thing is pretty terrible and might be so bad as to not use this technique (it may make the elements look worse on some screen resolutions).

Try it out and see what you think.

[Buster's Uncle]

Please stand by while your request is being processed.  We appreciate your business.