Drill To Aquifer - Twice!

[Buster's Uncle]

I noticed this because I like to squeeze an extra EC outta boreholes, which keep the aquifer in the square, not starting a river.

Watch what happens when I move this former onto the isolated puddle and hit "q" .  This happens everywhere, not just the poles.



Obviously, the game checks for adjacent water, not for whether there's river in the square.  It's hard to see if the water is there in a borehole with a former on it (or just a empty borehole square) and I have lost/wasted MORE former turns when I miscounted or forgot to count how many formers are drilling to aquifer where an aquifer already is.

How hard would it be to add a line of code checking for that and preventing it?

[scient]

Not even one line of code, more like one byte change to loop check.  Looks like mistake with setting range of loop checking through tiles.  Adding one more loop through checks the initial tile as well.

[Buster's Uncle]

You da man. 

BTW, contrary to what you said on Skype, the game at least displays those one-tile bodies of water as "river".

   

[scient]

No, I was incorrect.  The one square bodies are considered rivers but they aren't considered "river source" anymore.

[Buster's Uncle]

I read somewhere -I assume it was some sort of official documentation- that boreholes being deep holes, rivers flow into them and vanish.  The same is obviously true even when the source is in the same square.

...

OT side-question:  not too long ago, there was discussion of the old "14 Factions at once" question, probably in Modding.  Yitzi and kyrub seemed to agree that it wasn't feasible, if for no other reason than Planetary Council display taking too much room - as something of an authority on the graphic side, I'm not entirely persuaded (something might could be done with two rows of factions, IMAO). 

Are you interested in weighing in, and as a related side-issue, how do you feel about moving all patch discussion into Bug Reports, even the outright modding, not-so-much-bug-related stuff?  (I should solicit their opinions about moving things, too, especially Yitzi's.)

[scient]

Increasing amount of factions would be difficult because the game is designed to only handle 7 factions (with one native AI) as core part of engine.  Even adding one faction would require editing large amounts of code that it would be unfeasible without some kind of source.

As for moving all patch related discussion into here, I'd be fine with that.  Everything would be more concentrated.

[Yitzi]

Yeah, I'm fine with that.  You might want to rename it "Bug/Patch discussion" if you do that, though.

[Buster's Uncle]

Definitely - I was thinking "Bug Reports & Patch Discussion", but yours might be better for brevity. 

Anyone else?

[Buster's Uncle]

Okay, kybub was by yesterday and has had a chance to weigh in - so with apologies if he doesn't like the idea, (it can always be changed back if there's enough objection) I'm going to change the name and move any patch/bug threads I stumble over here. 

Anyone is welcome to point out threads that ought to go here - scient can move anything down from the ToE forum if he sees a report first, but I have to do threads from Modding.