Pop 128 bug

[Buster's Uncle]

I don't recall it being reported/patched.  Game-breaking bug when a base's population, at least player headquarters, reaches 128.  Pop goes to negative numbers and the game crashes within two or three before it builds back to zero, let alone one.

scient?  Anyone?

[scient]

This is because the population variable inside the base struct is treated as signed. This alone isn't the problem. The problem is that it's a signed byte so max is 127 before it rolls over to signed. There are ~269 references to this variable across 55-60 functions. About ~150 of these references are signed. Once these references are decompiled then I can start to fix this. Initially, treating the value as unsigned. Eventually, once all the base references (as in all the Base related code since this will change struct size) are complete I think the best method will be increase this value to int.