Brood Pit's attacking-from-base morale bonus stacks with Children's Creche

[EmpathCrawler]

I'm attaching my morale calculating spreadsheet. Ignore the last sheet because that was my first draft. I had the boolean options rendered quite nicely as checkboxes in Google Sheets but that didn't survive the export, oh well.

The first sheet is the algorithm as-is but including the riot fix.

The second sheet is the same algorithm with a few changed or tweaked parts addressing the most obvious bugs or mistakes in the math. I haven't iterated through all the combinations here. It might still spit out odd values.

The third sheet was just an example idea that tries to interpret the various sources of information into a coherent calculation.

[scient]

Nice break down! I'm just wrapping up testing some of other functions. Will see about proposing some code fixes this weekend.

[scient]

So I've been looking over everything, still haven't figured the best way to handle the SE morale. However, two simple fixes would be BP/CC double bonus and defending HQ.

Removing the double Brood Pit bonus when Children’s Creche is present is simple. I think it's pretty clear from manual and in game text files it should be an either/or situation. This is done by removing the following code segments:
From here to here and from here to here.

For +1 in defending HQ, you could insert above here the following code:

Code: [Select]

if (has_fac_built(FAC_HEADQUARTERS, baseIDDef)) { // bug fix: per manual
morale++; // "Units in a headquarters base automatically gain +1 Morale when defending."
}

[EmpathCrawler]

So I've been looking over everything, still haven't figured the best way to handle the SE morale. However, two simple fixes would be BP/CC double bonus and defending HQ.

Removing the double Brood Pit bonus when Children’s Creche is present is simple. I think it's pretty clear from manual and in game text files it should be an either/or situation. This is done by removing the following code segments:
From here to here and from here to here.

For +1 in defending HQ, you could insert above here the following code:

Code: [Select]

if (has_fac_built(FAC_HEADQUARTERS, baseIDDef)) { // bug fix: per manual
morale++; // "Units in a headquarters base automatically gain +1 Morale when defending."
}

Nice, that is all the lowest hanging fruit. The HQ bonus would have been really helpful for an AI Morgan I just wormed to death in my latest game.

As for the rest, I see these as the major contradictions that could make the math a lot easier if addressed:

1) The Creche MORALE-based adjustment, but not the Pit one, is doubly applied to conventional units if that unit is both homed in a Creched base and defending/sortieing from a Creched base. First in morale_veh, then in get_basic_offense/get_basic_defense. Why? Everything says that the Children's Creche effect is on units in the base square with no mention of the home base.

1b) Why does the Creche and Pit affect worms based on MORALE, anyway? You quoted helpx earlier saying the Brood Pit canceled lifecycle penalties, but there aren't any nor does MORALE affect lifecycle. Maybe whoever added the Brood Pit code didn't know that?

2) The Creche math is really wacky. What were they trying to do? I tried to make it simpler with no surprises in my sheet. Maybe it would make more sense without the duplication of effects, but I didn't model that yet.

3) The manual says that the Creche cancels all negative morale modifiers, but that is not true. It doesn't affect the (undocumented) home drone riot penalty or Soporific Gas Pods. Should it?