Yitzi's unofficial SMAX patch 3.3b

[Yitzi]

Ok, I found out what's happening, and it's not due to my patch:

A needlejet will regenerate its fuel when it reaches 0 movement in an airbase or base.  This can happen due to the "skip turn" (spacebar) action, which sets movement to 0, or by reaching the airbase/base in its last move, but will not happen with the "hold position" action.  Therefore, if a needlejet still has movement left and you have it hold position (or sentry (L)) in a base/airbase and then end turn while there is still movement left, it will regenerate that turn's fuel (since that's tracked with movement), but no more.

This is a fairly minor bug and not due to my patch, so while you can nominate it for fixing, it's not getting fast-tracked.

[ete]

It's also on the bug tracker https://github.com/OpenSMACX/OpenSMACX/issues/9 and has been around/known for a long time.

[VladaM]

Thanks for help, Is it good to know "how to refuel" 
"Backspace" key is my friend now 

But I have new "frozing" savegame - in attachment.

After new turn the game froze without error message.....

[Yitzi]

Freezes are usually extremely difficult to track down...if it doesn't happen in Kyrub's patch (unlikely) I can probably do something, but if it does then it'd probably have to wait until the decompilation project is done.

[Yitzi]

Well, I was able to determine that it's due to corrupted data: A unit is listed with "next unit in square" as itself.  So I should be able to edit the savegame to fix it...

[VladaM]

Thank you for help.

I am sick (flu) and this game is memory return to my colleague age, I played it in physics computer laboratory after the lectures.
There were 5 astrophysics and teoretical physics which played this game 
I was amazing times 

So you have my admiration and gratitude. I spend last 3 days in memories back in 1998/1999 

If its there some possibility of donation It will be glad to contribute some small amount.

Have a nice evening.

[Yitzi]

Thank you for help.

I am sick (flu) and this game is memory return to my colleague age, I played it in physics computer laboratory after the lectures.
There were 5 astrophysics and teoretical physics which played this game 
I was amazing times 

So you have my admiration and gratitude. I spend last 3 days in memories back in 1998/1999 

If its there some possibility of donation It will be glad to contribute some small amount.

Have a nice evening.

Thanks.  I don't really think I need a small donation (although the site would probably appreciate it), but if you happen to know of any available jobs in the New York area starting in May or June...

[VladaM]

I am from central europe (Czech republic) , It sound little bit familiar as Central park - but itsnt the same place 

So I am sorry - I've heard about New York only from TV series "Friends" and "How I Met Your Mother" 

[Yitzi]

Correction: It may actually be due to listing itself as "previous unit in square", but same idea (it lists itself as both, but I'm not certain which is which, and it doesn't really matter for purposes of fixing it...)

[Yitzi]

Okay, I've managed to produce a fixed savegame after ending the turn, which I'm attaching.

However, it does seem to be a bug in my patch, so I'll have to track it down and figure out where the problem is...

[VladaM]

Hi, I load damaged (and ALSO fixed) save and I found Believers troop in my city (I am in VENDETTA with her), but city is still mine.
So maybe this was the problem with the bad savegame - game save enemy troop in my city....
Thanks for help.

[Yitzi]

Hi, I load damaged (and ALSO fixed) save and I found Believers troop in my city (I am in VENDETTA with her), but city is still mine.
So maybe this was the problem with the bad savegame - game save enemy troop in my city....
Thanks for help.

Or it might be a second consequence of whatever the bug was...I still have to figure out what the problem is and how to fix it...

[Yitzi]

Bad news: Unlike what I first thought, the underlying bug was not introduced in my patch, but rather is present in Kyrub's, and probably Scient's and even the original as well.  And without a version of the game that lacks the bug, tracking down a data corruption bug is not feasible without access to source code.  So once the decompilation project is completed it can probably be fixed, but until then a case-by-case fix is probably the best that can be done; fortunately, it seems to be fairly rare.