Alpha Centauri 2

Community => Chiron News Network => Topic started by: Yitzi on April 28, 2014, 03:44:34 PM

Title: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on April 28, 2014, 03:44:34 PM

Yitzi's unofficial SMAX patch 2.5g

http://alphacentauri2.info/index.php?action=downloads;sa=view;down=171 (http://alphacentauri2.info/index.php?action=downloads;sa=view;down=171)

Fixed another bug.

As with all sub-versions, this requires all other files from 2.5.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on April 29, 2014, 06:32:16 PM

It appears to me as though Spoils of War, the faction bonus TECHSTEAL, and the targeted probe team techsteal operate in the manner of only allowing you to choose technologies that you have at least one of the prerequisites for. I will be done working on this feature once I fix the bug that effects how the second option in #DECIPHER operates with regards to stealing a faction's map.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on April 30, 2014, 04:04:27 PM

@Yitzi: Are you willing to add this feature to the patch once you get the other potential probe team costs in place?

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on April 30, 2014, 05:12:48 PM

Quote from: Dio on April 30, 2014, 04:04:27 PM

@Yitzi: Are you willing to add this feature to the patch once you get the other potential probe team costs in place?

If you write the code (just put in the code to test for any bit as the alphax option and I can adjust it to match where I end up putting that option), I can probably even include it before I do the other stuff.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on April 30, 2014, 05:52:23 PM

How do you add a alphax variable under your new system?

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on April 30, 2014, 08:49:56 PM

Quote from: Dio on April 30, 2014, 05:52:23 PM

How do you add a alphax variable under your new system?

The 585xxx area loads them; in order to avoid conflicts, though, simply assume when writing your code that it's a memory address (for this, a single bit will suffice) and check its value.  Then you can just tell it to check it (for a bit, it would be TEST BYTE PTR DS:[xxxxxxxx], xx); just fill in the x's however you want and I can change them and take care of loading the variable when I add it to my patch.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on May 01, 2014, 04:00:07 AM

Is this what you would want?
0058571B      A3 23015A00                     mov dword ptr ds:[5A0123], eax
00585720      F600 02                         test byte ptr ds:[eax], 2

What purpose would this serve? The only coding change needed to make the DECIPHER script function is to change jnz short terranx_.005A013A to je short terranx_.005A013A.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on May 01, 2014, 04:28:19 AM

Quote from: Dio on May 01, 2014, 04:00:07 AM

Is this what you would want?
0058571B      A3 23015A00                     mov dword ptr ds:[5A0123], eax
00585720      F600 02                         test byte ptr ds:[eax], 2

What purpose would this serve? The only coding change needed to make the DECIPHER script function is to change jnz short terranx_.005A013A to je short terranx_.005A013A.

Firstly, I didn't realize that no further changes are necessary to enable it.

However, even so, it would serve the purpose of making it so that people who want to play without that option can.  Unlike your previous changes, it's an actual change to gameplay, so unless consensus is that it would be a bugfix, people should have the option.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on May 01, 2014, 04:41:38 AM

Quote from: Yitzi on May 01, 2014, 04:28:19 AM

Quote from: Dio on May 01, 2014, 04:00:07 AM

Is this what you would want?
0058571B      A3 23015A00                     mov dword ptr ds:[5A0123], eax
00585720      F600 02                         test byte ptr ds:[eax], 2

What purpose would this serve? The only coding change needed to make the DECIPHER script function is to change jnz short terranx_.005A013A to je short terranx_.005A013A.

Firstly, I didn't realize that no further changes are necessary to enable it.

However, even so, it would serve the purpose of making it so that people who want to play without that option can.  Unlike your previous changes, it's an actual change to gameplay, so unless consensus is that it would be a bugfix, people should have the option.

The topic on the Theory of Everything I started seems to indictate most of the respondents are fine with having additional options.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Buster's Uncle on May 01, 2014, 06:04:11 AM

Apologies to everyone.  The scenario threads are an autopost when you add something to Downloads, and I'm posting a lot to Downloads this week, catching up on something I should have taken care of two years ago.

Altera Centauri is a large but finite scenario set- I'm over a third of the way through, and  there's no point in turning off the autoposts now - the damage was already done yesterday.  By sometime Saturday, it should be over, and we can bump the important stuff back up.

Tomorrow, there will probably be a temporary respite.  There's a GotM to get ready for release while it's still the 1st of May here, and that'll have to come first.  Thank you for your patience while I do the necessary work to get our house in order before BE comes out.

-Also, Yitzi, note that I'm 10 posts from another Obnoxious PC Thread post... ;)

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on May 01, 2014, 02:24:00 PM

Quote from: Dio on May 01, 2014, 04:41:38 AM

Quote from: Yitzi on May 01, 2014, 04:28:19 AM

Quote from: Dio on May 01, 2014, 04:00:07 AM

Is this what you would want?
0058571B      A3 23015A00                     mov dword ptr ds:[5A0123], eax
00585720      F600 02                         test byte ptr ds:[eax], 2

What purpose would this serve? The only coding change needed to make the DECIPHER script function is to change jnz short terranx_.005A013A to je short terranx_.005A013A.

Firstly, I didn't realize that no further changes are necessary to enable it.

However, even so, it would serve the purpose of making it so that people who want to play without that option can.  Unlike your previous changes, it's an actual change to gameplay, so unless consensus is that it would be a bugfix, people should have the option.

The topic on the Theory of Everything I started seems to indictate most of the respondents are fine with having additional options.

That was about whether most people would like to see it, but that's not enough to remove the option of having the old way.  The only time it's ok to remove the old way is if that was a bug...and there doesn't seem to be any discussion of that question.  I'll put up a poll on the issue.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on May 01, 2014, 03:11:01 PM

As far as I know, my change to the code does not change how the old way of probe tech steal operates. The first option in the script is identical to the original method of probe tech steal. In addition, the alphax variable for disabling probe tech steal effects both options.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Dio on May 01, 2014, 03:18:44 PM

How can you disable one option with an alphax variable when they both go through the majority of the same procedure?

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on May 01, 2014, 05:50:04 PM

Quote from: Dio on May 01, 2014, 03:18:44 PM

How can you disable one option with an alphax variable when they both go through the majority of the same procedure?

Simple: Have it test a particular bit, and if the bit is off, jump past that procedure.  Actually, having one variable control techsteal at all and another for targeted is redundant, so instead that variable would be changed to random techsteal, and where it tests if techsteal is possible it would test if either type is possible; if only one type is possible it uses that, and if both are it would provide the option.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: stecauri on May 01, 2014, 09:23:18 PM

Hello

I'd like to help out a bit and report a bug I stumbled upon.

The game crashes when setting the Battle Ogre Mk1 as primary defender in the following savegame.

Edit: Oh and I'm using gog version.

Title: Re: Yitzi's unofficial SMAX patch 2.5g
Post by: Yitzi on May 01, 2014, 10:03:08 PM

It works fine for me (with my version), so it may have been fixed in that process.  (I did, however, find another bug in the process of testing it, which I intend to post a fix for shortly.)